[GH-ISSUE #88] Remove copy of getkey procedure from weapons.asm #257

New Issue

2026-05-20T22:35:02+02:00

Pecus commented

2026-05-20 22:35:02 +02:00

Originally created by @pkali on GitHub (Jun 4, 2022).
Original GitHub issue: https://github.com/pkali/scorch_src/issues/88

Originally assigned to: @pkali on GitHub.

a copy in weapons.asm (in .proc BeforeFire) is very slightly different from the base .proc getkey.
Consider removing code duplication.

Originally created by @pkali on GitHub (Jun 4, 2022). Original GitHub issue: https://github.com/pkali/scorch_src/issues/88 Originally assigned to: @pkali on GitHub. a copy in `weapons.asm` (in `.proc BeforeFire`) is very slightly different from the base `.proc getkey`. Consider removing code duplication.

Pecus added the optimization label 2026-05-20 22:35:02 +02:00

Pecus closed this issue

2026-05-20 22:35:02 +02:00

Pecus commented

2026-05-20 22:35:03 +02:00

@pkali commented on GitHub (Jun 5, 2022):

not worth pursuing

@pkali commented on GitHub (Jun 5, 2022): not worth pursuing

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/scorch_src#257

[GH-ISSUE #88] Remove copy of getkey procedure from weapons.asm #257

[GH-ISSUE #88] Remove copy of `getkey` procedure from weapons.asm #257