[GH-ISSUE #63] tank says goodbye when invisible #238

New Issue

2026-05-20T22:34:51+02:00

Pecus commented

2026-05-20 22:34:51 +02:00

Originally created by @bocianu on GitHub (May 16, 2022).
Original GitHub issue: https://github.com/pkali/scorch_src/issues/63

Originally assigned to: @Pecusx on GitHub.

This is not a bug, it is more "User Experience" issue.
When players gets killed it says it's last "goodbye" sentence,
but when the message shows on the screen, the tank is already invisible.

I think it should disappear AFTER the farewell.
Maybe toegether with the sentence?

Originally created by @bocianu on GitHub (May 16, 2022). Original GitHub issue: https://github.com/pkali/scorch_src/issues/63 Originally assigned to: @Pecusx on GitHub. This is not a bug, it is more "User Experience" issue. When players gets killed it says it's last "goodbye" sentence, but when the message shows on the screen, the tank is already invisible. I think it should disappear AFTER the farewell. Maybe toegether with the sentence?

Pecus added the enhancement design labels 2026-05-20 22:34:51 +02:00

Pecus closed this issue

2026-05-20 22:34:52 +02:00

Pecus commented

2026-05-20 22:34:52 +02:00

@pkali commented on GitHub (May 16, 2022):

'tis ain't no easy, man. but we'll try our best :]

@pkali commented on GitHub (May 16, 2022): 'tis ain't no easy, man. but we'll try our best :]

Pecus commented

2026-05-20 22:34:52 +02:00

@pkali commented on GitHub (May 21, 2022):

OK, so I did some code analysis and the result is that this change is surprisingly difficult. This is because the whole logic of the disappearing tank is somewhat reversed - all tanks disappear and then only those still alive reappear. This is governed in a completely different place from displaying these goodbye texts. Right now I must postpone this issue, maybe @Pecusx will have a better idea of how to do it?

@pkali commented on GitHub (May 21, 2022): OK, so I did some code analysis and the result is that this change is surprisingly difficult. This is because the whole logic of the disappearing tank is somewhat reversed - all tanks disappear and then only those still alive reappear. This is governed in a completely different place from displaying these goodbye texts. Right now I must postpone this issue, maybe @Pecusx will have a better idea of how to do it?

Pecus commented

2026-05-20 22:34:52 +02:00

@pkali commented on GitHub (May 23, 2022):

Just wanted to add that although this is basically a non-issue when you kill a single tank, it is a pain when you drop a large weapon, destroy 3 tanks and they talk for a long while from the nothingness...

@pkali commented on GitHub (May 23, 2022): Just wanted to add that although this is basically a non-issue when you kill a single tank, it is a pain when you drop a large weapon, destroy 3 tanks and they talk for a long while from the nothingness...

Pecus commented

2026-05-20 22:34:53 +02:00

@pkali commented on GitHub (May 30, 2022):

I call it done in 142 - it is not perfect, but as good as it gets without a heavy rewrite - now tanks say goodbye when visible. This fails when many tanks has been destroyed and some dying weapons cleared the area. Still better than it was.

@pkali commented on GitHub (May 30, 2022): I call it done in 142 - it is not perfect, but as good as it gets without a heavy rewrite - now tanks say goodbye when visible. This fails when many tanks has been destroyed and some dying weapons cleared the area. Still better than it was.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/scorch_src#238